Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1591)

Unified Diff: mojo/tools/get_test_list.py

Issue 1381643003: Run mojo_benchmark on the perf bot. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/get_test_list.py
diff --git a/mojo/tools/get_test_list.py b/mojo/tools/get_test_list.py
index c59602c10244b174054ca4e0120d7a7db2ceaa19..9488636efc8cc887e104e0145943773b665e4693 100755
--- a/mojo/tools/get_test_list.py
+++ b/mojo/tools/get_test_list.py
@@ -212,6 +212,17 @@ def GetTestList(config, verbose_count=0):
AddEntry(test_name, command)
+ # Benchmarks -----------------------------------------------------------------
+
+ if target_os == Config.OS_LINUX and ShouldRunTest(Config.TEST_TYPE_PERF):
viettrungluu 2015/10/01 15:22:06 Seems kind of pointless to run them and not record
ppi 2015/10/01 15:25:04 This is meant to catch breakages, e.g. benchmarks
viettrungluu 2015/10/01 19:38:39 This suggests to me that you need actual tests for
+ command = ([os.path.join("mojo", "devtools", "common", "mojo_benchmark"),
+ os.path.join("mojo", "tools", "data", "benchmarks")] +
+ verbose_flags)
+ if not config.is_debug:
+ command.append("--release")
+
+ AddEntry("benchmarks", command)
+
# Integration tests ----------------------------------------------------------
if target_os == Config.OS_ANDROID and ShouldRunTest(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698