Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1381643003: Run mojo_benchmark on the perf bot. (Closed)

Created:
5 years, 2 months ago by ppi
Modified:
5 years, 2 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Run mojo_benchmark on the perf bot. This makes the Linux perf bot run mojo benchmarks.

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M mojo/tools/get_test_list.py View 1 1 chunk +11 lines, -0 lines 3 comments Download

Messages

Total messages: 5 (1 generated)
ppi
Hi Trung, ptal.
5 years, 2 months ago (2015-10-01 14:35:22 UTC) #2
viettrungluu
https://codereview.chromium.org/1381643003/diff/20001/mojo/tools/get_test_list.py File mojo/tools/get_test_list.py (right): https://codereview.chromium.org/1381643003/diff/20001/mojo/tools/get_test_list.py#newcode217 mojo/tools/get_test_list.py:217: if target_os == Config.OS_LINUX and ShouldRunTest(Config.TEST_TYPE_PERF): Seems kind of ...
5 years, 2 months ago (2015-10-01 15:22:06 UTC) #3
ppi
https://codereview.chromium.org/1381643003/diff/20001/mojo/tools/get_test_list.py File mojo/tools/get_test_list.py (right): https://codereview.chromium.org/1381643003/diff/20001/mojo/tools/get_test_list.py#newcode217 mojo/tools/get_test_list.py:217: if target_os == Config.OS_LINUX and ShouldRunTest(Config.TEST_TYPE_PERF): On 2015/10/01 15:22:06, ...
5 years, 2 months ago (2015-10-01 15:25:04 UTC) #4
viettrungluu
5 years, 2 months ago (2015-10-01 19:38:39 UTC) #5 
https://codereview.chromium.org/1381643003/diff/20001/mojo/tools/get_test_lis...
File mojo/tools/get_test_list.py (right):

https://codereview.chromium.org/1381643003/diff/20001/mojo/tools/get_test_lis...
mojo/tools/get_test_list.py:217: if target_os == Config.OS_LINUX and
ShouldRunTest(Config.TEST_TYPE_PERF):
On 2015/10/01 15:25:04, ppi wrote:
> On 2015/10/01 15:22:06, viettrungluu wrote:
> > Seems kind of pointless to run them and not record results.
> 
> This is meant to catch breakages, e.g. benchmarks no longer producing results.

This suggests to me that you need actual tests for the benchmarks. Just running
this here will only catch relatively trivial errors. Moreover, this isn't run on
the trybots, etc.

> 
> Before we record results we need to teach mojo_benchmark about the compatible
> format, I was planning to do that separately.

Powered by Google App Engine
This is Rietveld 408576698