Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1381633005: [heap] Properly reset flags for partially aborted evacuation candidates. (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Properly reset flags for partially aborted evacuation candidates. See bug description. R=hpayer@chromium.org BUG=chromium:538257 LOG=N Committed: https://crrev.com/5ef26f3a6b2a0efd7458be6f11b34cae876d51f4 Cr-Commit-Position: refs/heads/master@{#31070}

Patch Set 1 #

Patch Set 2 : Add test case for symptom #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -6 lines) Patch
M src/heap/mark-compact.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M test/cctest/test-heap.cc View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Michael Lippautz
PTAL
5 years, 2 months ago (2015-10-02 08:56:17 UTC) #2
Hannes Payer (out of office)
Add a test case, e.g. the CF repro.
5 years, 2 months ago (2015-10-02 08:59:38 UTC) #3
Hannes Payer (out of office)
As discussed offline, a test is tricky to get for this scenario. LGTM
5 years, 2 months ago (2015-10-02 10:58:02 UTC) #4
Michael Lippautz
PTAL. The test case is only working because we have proper DCHECKs in Sweep().
5 years, 2 months ago (2015-10-02 11:19:50 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381633005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381633005/20001
5 years, 2 months ago (2015-10-02 11:21:05 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-02 11:42:46 UTC) #9
Michael Lippautz
As discussed offline: This test is better than no test.
5 years, 2 months ago (2015-10-02 11:46:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381633005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381633005/20001
5 years, 2 months ago (2015-10-02 11:47:33 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-02 11:50:02 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 11:50:23 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ef26f3a6b2a0efd7458be6f11b34cae876d51f4
Cr-Commit-Position: refs/heads/master@{#31070}

Powered by Google App Engine
This is Rietveld 408576698