Issue 138163015: More fixes to enable ios build with policy.

Issue 138163015: More fixes to enable ios build with policy. (Closed)

Created:
6 years, 11 months ago by Joao da Silva

Modified:
6 years, 11 months ago

Reviewers:
jochen (gone - plz use gerrit), dconnelly, justincohen

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

More fixes to enable ios build with policy. This change fixes //chrome code that breaks when built with policy enabled on ios. BUG=275292 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246375

Patch Set 1 #

Patch Set 2 : removed obsolete files from gyp #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -40 lines)			Patch
M	build/ios/grit_whitelist.txt	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_process_platform_part_base.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_handler_list_factory.cc	View		10 chunks	+23 lines, -20 lines	0 comments	Download
M	chrome/browser/policy/policy_helpers.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_io_data.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/profiles/profile_io_data.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+44 lines, -16 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

Alright, this was forked off the other CL and doesn't add new stuff to //chrome, ...

6 years, 11 months ago (2014-01-22 14:40:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/138163015/180001

6 years, 11 months ago (2014-01-22 15:13:43 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=217037

6 years, 11 months ago (2014-01-22 15:40:43 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/138163015/180001

6 years, 11 months ago (2014-01-22 15:45:53 UTC) #6

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages