Issue 138163004: Remove m_shouldUpdateWhileOffscreen member from FrameView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138163004: Remove m_shouldUpdateWhileOffscreen member from FrameView (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
esprehn, adamk

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove m_shouldUpdateWhileOffscreen member from FrameView Remove m_shouldUpdateWhileOffscreen member from FrameView. It is never updated and it is always true. We should also get rid of the shouldUpdate() method as it returns true unconditionally. R=esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165183

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -32 lines)			Patch
	M	Source/core/frame/FrameView.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
	M	Source/core/frame/FrameView.cpp	View		4 chunks	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/138163004/1

6 years, 11 months ago (2014-01-16 01:22:31 UTC) #3

Message was sent while issue was closed.

Change committed as 165183

Expand Messages | Collapse Messages