Defer media loading while on cellular networks.

third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 86 matching lines @@
         observerList->zeroedObservers.append(index);
     }
 
     if (!observerList->iterating && !observerList->zeroedObservers.isEmpty())
         collectZeroedObservers(observerList, context);
 }
 
 void NetworkStateNotifier::setTestUpdatesOnly(bool updatesOnly)
 {
     ASSERT(isMainThread());
+
+    // Reset state to default when entering or leaving test mode.
+    if (updatesOnly || m_testUpdatesOnly) {

[philipj_slow, 2015/10/01 09:24:07]

Should this say updatesOnly != m_testUpdatseOnly in order to match the comment?
If so an early `if (m_testUpdatesOnly == updatesOnly) return` would be
equivalent and more clear.

Also, are the new tests doing something special to make this necessary?

[DaleCurtis, 2015/10/01 19:25:54]

w/o this if I disable the setWebConnectionFortest() in one layout test, but not
the other, both will pass so long as the one that sets the values runs first. 
This ensures there's no ordering dependencies.

[DaleCurtis, 2015/10/20 21:56:51]

Done.

+        m_isOnLine = true;
+        m_type = WebConnectionTypeOther;
+        m_maxBandwidthMbps = std::numeric_limits<double>::infinity();
+    }
+
     m_testUpdatesOnly = updatesOnly;
 }
 
 void NetworkStateNotifier::setWebConnectionForTest(WebConnectionType type, double maxBandwidthMbps)
 {
     ASSERT(isMainThread());
     ASSERT(m_testUpdatesOnly);
     setWebConnectionImpl(type, maxBandwidthMbps);
 }
 
@@ skipping 56 matching lines @@
 
     list->zeroedObservers.clear();
 
     if (list->observers.isEmpty()) {
         MutexLocker locker(m_mutex);
         m_observers.remove(context); // deletes list
     }
 }
 
 } // namespace blink