third_party/WebKit/LayoutTests/media/video-preload-override-cellular.html - Issue 1381613003: Defer media loading while on cellular networks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-preload-override-cellular.html

Issue 1381613003: Defer media loading while on cellular networks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/video-preload-default-cellular.html ('K') | « third_party/WebKit/LayoutTests/media/video-preload-default-cellular-expected.html ('k') | third_party/WebKit/LayoutTests/media/video-preload-override-cellular-expected.html » ('j') | third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Tests that preload is overridden to none for cellular connections.</title >
	philipj_slow 2015/10/01 09:24:07 Since this test is almost identical, what you coul Since this test is almost identical, what you could do is just have a video element in both tests and include the shared js that would do document.querySelector("video"). DaleCurtis 2015/10/20 21:56:51 Kind of done; refactored to a shared js, but async Show quoted text On 2015/10/01 09:24:07, philipj wrote: > Since this test is almost identical, what you could do is just have a video > element in both tests and include the shared js that would do > document.querySelector("video"). Kind of done; refactored to a shared js, but async_test() seems to need to be in the main html or it won't wait for the DOM to load completely -- subsequently it can't find the video tag via querySelector.
	3 <style>

	4 /* Use a black background to see failures; the video clip is a white square. */

	5 body { background-color: black; }

	6 </style>

	7 <script>

	8 if (window.testRunner)

	9 testRunner.waitUntilDone();

	10

	11 function startTest() {

	12 if (window.internals) {

	13 internals.setNetworkStateNotifierTestOnly(true);

	14 internals.setNetworkConnectionInfo('cellular', 2.0);

	15 }

	16

	17 var video = document.querySelector('video');

	18 video.addEventListener("suspend", function () {

	19 if (window.internals)

	20 internals.setNetworkStateNotifierTestOnly(false);

	21

	22 if (window.testRunner)

	23 testRunner.notifyDone();

	24 });

	25

	26 video.src = "resources/test-positive-start-time.webm"

	27 }

	28

	29 window.addEventListener('load', startTest, false);

	30 </script>

	31 <video preload="metadata"></video>

OLD	NEW