Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 1381603005: Revert of Fixes for contenteditable caret and selection handling in Windows. (Closed)

Created:
5 years, 2 months ago by nektarios
Modified:
5 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fixes for contenteditable caret and selection handling in Windows. (patchset #14 id:260001 of https://codereview.chromium.org/1377733002/ ) Reason for revert: Breaks reporting of the selection when the focus is on a text leaf that is not an immediate sibling of the nearest non-text ancestor of the current object. Original issue's description: > Fixes for contenteditable caret and selection handling in Windows. > > 1. Reports a valid selection endpoint even when either the start or end of the selection fall outside the object. > <div contenteditable>this <selection_start>is a <a href="#">link<selection_end></a>.</div> > selection_start on the link element would be given as 0. > 2. Does not report any selection on a parent object if there is no selection on the child objects. > <div contenteditable><p>hi</p></div> > nSelections on the div should be 0. > BUG=527440 > R=dmazzoni@chromium.org > > Committed: https://crrev.com/d816a9211de3c355f0de5051fa5c517ef2321e1a > Cr-Commit-Position: refs/heads/master@{#352236} TBR=dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=527440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -268 lines) Patch
M content/browser/accessibility/browser_accessibility.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_auralinux.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_mac.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.h View 4 chunks +6 lines, -19 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 11 chunks +48 lines, -160 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 7 chunks +14 lines, -31 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/accessibility/renderer_accessibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-searchbox-with-selection-expected-win.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/aria/aria-textbox-with-selection-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/contenteditable-descendants.html View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/contenteditable-descendants-expected-win.txt View 1 chunk +25 lines, -25 lines 0 comments Download
M content/test/data/accessibility/html/input-password-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/input-text-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/input-text-with-selection-expected-win.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/html/textarea-with-selection-expected-win.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nektarios
Created Revert of Fixes for contenteditable caret and selection handling in Windows.
5 years, 2 months ago (2015-10-03 04:46:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381603005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381603005/1
5 years, 2 months ago (2015-10-03 04:46:47 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-03 04:46:48 UTC) #4
dmazzoni
Ping - do you still want this or should we close this?
5 years, 1 month ago (2015-11-06 16:46:14 UTC) #5
chromium-reviews
5 years, 1 month ago (2015-11-06 17:10:28 UTC) #6
I should close this.
I made a followup patch instead.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698