Issue 13816005: Add preprocessor to reloadOptions in chrome.devtools.inspectedWindow.reload().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13816005: Add preprocessor to reloadOptions in chrome.devtools.inspectedWindow.reload(). (Closed)

Created:
7 years, 8 months ago by johnjbarton

Modified:
7 years, 5 months ago

Reviewers:
caseq, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add preprocessor to reloadOptions in chrome.devtools.inspectedWindow.reload(). Add options.preprocessor to ExtensionServer.js and provide a default empty string value. Add test case to extensions-reload.html to verify preprocessingScript is run. BUG=229971 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154574

Patch Set 1 #

Patch Set 2 : rebase, clean up #

Patch Set 3 : remove unnecessary include #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -1 line)			Patch
M	LayoutTests/inspector/extensions/extensions-reload.html	View	1 2	2 chunks	+20 lines, -0 lines	0 comments	Download
M	LayoutTests/inspector/extensions/extensions-reload-expected.txt	View	1 2	2 chunks	+10 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/ExtensionServer.js	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/externs.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnjbarton@chromium.org/13816005/5001

7 years, 5 months ago (2013-07-19 14:46:44 UTC) #3

Message was sent while issue was closed.

Change committed as 154574

Expand Messages | Collapse Messages