go/src/infra/tools/cipd/internal/messages/generate.go - Issue 1381583007: cipd: Implement local cache for ResolveVersion(...) call with tags.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: go/src/infra/tools/cipd/internal/messages/generate.go

Issue 1381583007: cipd: Implement local cache for ResolveVersion(...) call with tags. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@cipd-init

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« go/src/infra/tools/cipd/internal/checksum.go ('K') | « go/src/infra/tools/cipd/internal/checksum.go ('k') | go/src/infra/tools/cipd/internal/messages/messages.proto » ('j') | go/src/infra/tools/cipd/internal/tagcache.go » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // +build !windows	5 //go:generate protoc --go_out=. messages.proto

6	6

7 package main	7 package messages

8	8

9 import (	9 import (

10 » "syscall"	10 » "github.com/golang/protobuf/proto"

11 )	11 )

12	12

13 var serverStartParams = &syscall.SysProcAttr{Setpgid: true}	13 var _ = proto.Marshal
	Vadim Sh. 2015/09/30 03:50:00 this is needed to make "proto" package actually us this is needed to make "proto" package actually used, so that "go get" can potentially fetch it, so that if go-generated code is not generated yet, proto is still around. It's mostly unnecessary in our pinned universe. But I copy-pasted the pattern from elsewhere (I think dnj@ uses it), and it sort of cute. nodir 2015/09/30 19:08:23 Acknowledged. Show quoted text On 2015/09/30 03:50:00, Vadim Sh. wrote: > this is needed to make "proto" package actually used, so that "go get" can > potentially fetch it, so that if go-generated code is not generated yet, proto > is still around. > > It's mostly unnecessary in our pinned universe. But I copy-pasted the pattern > from elsewhere (I think dnj@ uses it), and it sort of cute. Acknowledged.
OLD	NEW