Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1381553002: Chromecast GN: Set use_ozone=1 when is_android=0 (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 2 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast GN: Set use_ozone=1 when is_android=0 This CL makes use_ozone in GN better mirror use_ozone in GYP. According to common.gypi, use_ozone should be '0' when compiling Chromecast for Android. BUG=None TESt=None Committed: https://crrev.com/a6fba430209b9239e6a8833d30168529f710d83f Cr-Commit-Position: refs/heads/master@{#351474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/ui.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pkotwicz
agrieve@ PTAL
5 years, 2 months ago (2015-09-29 20:52:25 UTC) #2
agrieve
On 2015/09/29 20:52:25, pkotwicz wrote: > agrieve@ PTAL lgtm
5 years, 2 months ago (2015-09-30 01:39:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381553002/1
5 years, 2 months ago (2015-09-30 01:48:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 02:27:21 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 02:28:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6fba430209b9239e6a8833d30168529f710d83f
Cr-Commit-Position: refs/heads/master@{#351474}

Powered by Google App Engine
This is Rietveld 408576698