Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1381543005: [cross-context] create new function prototypes in the context of the function (Closed)

Created:
5 years, 2 months ago by Camillo Bruni
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Toon Verwaest
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cross-context] create new function prototypes in the context of the function BUG=v8:4217 LOG=Y Committed: https://crrev.com/1cb899046ccf783fa3a17f1d832e30b2339cd532 Cr-Commit-Position: refs/heads/master@{#31074}

Patch Set 1 #

Patch Set 2 : removing unused code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M src/objects.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/cross-realm-filtering.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Camillo Bruni
PTAL
5 years, 2 months ago (2015-10-01 14:36:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381543005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381543005/20001
5 years, 2 months ago (2015-10-01 14:40:57 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-01 15:04:39 UTC) #6
rossberg
lgtm
5 years, 2 months ago (2015-10-02 13:00:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381543005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381543005/20001
5 years, 2 months ago (2015-10-02 13:28:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-02 13:30:09 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 13:30:30 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1cb899046ccf783fa3a17f1d832e30b2339cd532
Cr-Commit-Position: refs/heads/master@{#31074}

Powered by Google App Engine
This is Rietveld 408576698