Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1381523002: Revert of Implement SkImageFilter::Cache with SkResourceCache. (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Implement SkImageFilter::Cache with SkResourceCache. (patchset #8 id:140001 of https://codereview.chromium.org/1370323002/ ) Reason for revert: Landed PS8 temporarily to trigger the perf bots. Original issue's description: > Implement SkImageFilter::Cache with SkResourceCache. > > The single global cache now uses the global SkResourceCache, > and any Create()ed cache uses a local SkResourceCache. > > No real public API changes (and only deletes). > > I don't see any pixel diffs on .skps or GMs. > Don't see any significant perf difference on 8888 or gpu configs. > DM peak memory usage did drop by about 113M, close to the 128M cache size. > > BUG=skia:3662 > > Landing PS8 temporarily to trigger the perf bots. > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/75135d8ae1aa12e8e6bfce63291e5e876a77546f TBR=reed@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3662 Committed: https://skia.googlesource.com/skia/+/242397a1c95e34e3e2e5e85c85c81090317115cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -105 lines) Patch
M include/core/SkImageFilter.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/core/SkImageFilter.cpp View 3 chunks +89 lines, -105 lines 0 comments Download
M src/core/SkResourceCache.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein_C
Created Revert of Implement SkImageFilter::Cache with SkResourceCache.
5 years, 2 months ago (2015-09-29 19:16:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381523002/1
5 years, 2 months ago (2015-09-29 19:16:56 UTC) #2
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 19:17:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/242397a1c95e34e3e2e5e85c85c81090317115cb

Powered by Google App Engine
This is Rietveld 408576698