Remove unused Allocator::{enter,leave}NoAllocationScope().

Remove unused Allocator::{enter,leave}NoAllocationScope().

R=haraken
BUG=

Committed: https://crrev.com/82bfd3e8a79a01a9564e44476c9f104275eab4a2
Cr-Commit-Position: refs/heads/master@{#351740}

[sof, 2015-09-30 20:45:02]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[sof, 2015-09-30 20:45:03]

please take a look.

[haraken, 2015-09-30 23:42:01]

LGTM


On Thu, Oct 1, 2015 at 5:45 AM, <sigbjornf@opera.com> wrote:

> Reviewers: tkent, haraken,
>
> Message:
> please take a look.
>
> Description:
> Remove unused Allocator::{enter,leave}NoAllocationScope().
>
> R=
> BUG=
>
> Please review this at https://codereview.chromium.org/1381493006/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+0, -16 lines):
>   M third_party/WebKit/Source/platform/heap/HeapAllocator.h
>   M third_party/WebKit/Source/wtf/DefaultAllocator.h
>
>
> Index: third_party/WebKit/Source/platform/heap/HeapAllocator.h
> diff --git a/third_party/WebKit/Source/platform/heap/HeapAllocator.h
> b/third_party/WebKit/Source/platform/heap/HeapAllocator.h
> index
>
ae487e5b217520433af855ffa5e0ac87e712d985..ece36a275040a73106fe8af48d2de4ae2de2c1a8
> 100644
> --- a/third_party/WebKit/Source/platform/heap/HeapAllocator.h
> +++ b/third_party/WebKit/Source/platform/heap/HeapAllocator.h
> @@ -161,20 +161,6 @@ public:
>          return *other;
>      }
>
> -    static void enterNoAllocationScope()
> -    {
> -#if ENABLE(ASSERT)
> -        ThreadState::current()->enterNoAllocationScope();
> -#endif
> -    }
> -
> -    static void leaveNoAllocationScope()
> -    {
> -#if ENABLE(ASSERT)
> -        ThreadState::current()->leaveNoAllocationScope();
> -#endif
> -    }
> -
>      static void enterGCForbiddenScope()
>      {
>          ThreadState::current()->enterGCForbiddenScope();
> Index: third_party/WebKit/Source/wtf/DefaultAllocator.h
> diff --git a/third_party/WebKit/Source/wtf/DefaultAllocator.h
> b/third_party/WebKit/Source/wtf/DefaultAllocator.h
> index
>
48160e93b6778b05f91662effde83ccbd8acbdfb..7ff205efcf0360f4cd69769797685130ffac9a80
> 100644
> --- a/third_party/WebKit/Source/wtf/DefaultAllocator.h
> +++ b/third_party/WebKit/Source/wtf/DefaultAllocator.h
> @@ -176,8 +176,6 @@ public:
>          return *other;
>      }
>
> -    static void enterNoAllocationScope() { }
> -    static void leaveNoAllocationScope() { }
>      static void enterGCForbiddenScope() { }
>      static void leaveGCForbiddenScope() { }
>
>
>
>


-- 
Kentaro Hara, Tokyo, Japan

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[haraken, 2015-09-30 23:42:02]

LGTM


On Thu, Oct 1, 2015 at 5:45 AM, <sigbjornf@opera.com> wrote:

> Reviewers: tkent, haraken,
>
> Message:
> please take a look.
>
> Description:
> Remove unused Allocator::{enter,leave}NoAllocationScope().
>
> R=
> BUG=
>
> Please review this at https://codereview.chromium.org/1381493006/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+0, -16 lines):
>   M third_party/WebKit/Source/platform/heap/HeapAllocator.h
>   M third_party/WebKit/Source/wtf/DefaultAllocator.h
>
>
> Index: third_party/WebKit/Source/platform/heap/HeapAllocator.h
> diff --git a/third_party/WebKit/Source/platform/heap/HeapAllocator.h
> b/third_party/WebKit/Source/platform/heap/HeapAllocator.h
> index
>
ae487e5b217520433af855ffa5e0ac87e712d985..ece36a275040a73106fe8af48d2de4ae2de2c1a8
> 100644
> --- a/third_party/WebKit/Source/platform/heap/HeapAllocator.h
> +++ b/third_party/WebKit/Source/platform/heap/HeapAllocator.h
> @@ -161,20 +161,6 @@ public:
>          return *other;
>      }
>
> -    static void enterNoAllocationScope()
> -    {
> -#if ENABLE(ASSERT)
> -        ThreadState::current()->enterNoAllocationScope();
> -#endif
> -    }
> -
> -    static void leaveNoAllocationScope()
> -    {
> -#if ENABLE(ASSERT)
> -        ThreadState::current()->leaveNoAllocationScope();
> -#endif
> -    }
> -
>      static void enterGCForbiddenScope()
>      {
>          ThreadState::current()->enterGCForbiddenScope();
> Index: third_party/WebKit/Source/wtf/DefaultAllocator.h
> diff --git a/third_party/WebKit/Source/wtf/DefaultAllocator.h
> b/third_party/WebKit/Source/wtf/DefaultAllocator.h
> index
>
48160e93b6778b05f91662effde83ccbd8acbdfb..7ff205efcf0360f4cd69769797685130ffac9a80
> 100644
> --- a/third_party/WebKit/Source/wtf/DefaultAllocator.h
> +++ b/third_party/WebKit/Source/wtf/DefaultAllocator.h
> @@ -176,8 +176,6 @@ public:
>          return *other;
>      }
>
> -    static void enterNoAllocationScope() { }
> -    static void leaveNoAllocationScope() { }
>      static void enterGCForbiddenScope() { }
>      static void leaveGCForbiddenScope() { }
>
>
>
>


-- 
Kentaro Hara, Tokyo, Japan

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[haraken, 2015-09-30 23:53:52]

LGTM

[sof, 2015-10-01 05:19:22]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-10-01 05:20:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1381493006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1381493006/1

[commit-bot: I haz the power, 2015-10-01 06:53:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-01 06:54:02]

Patchset 1 (id:??) landed as
https://crrev.com/82bfd3e8a79a01a9564e44476c9f104275eab4a2
Cr-Commit-Position: refs/heads/master@{#351740}