src/codec/SkBmpCodec.cpp - Issue 1381483002: Call rewindIfNeeded in SkCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkBmpCodec.cpp

Issue 1381483002: Call rewindIfNeeded in SkCodec (Closed) Base URL: https://skia.googlesource.com/skia.git@codecSDmerge

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkBmpCodec.cpp

diff --git a/src/codec/SkBmpCodec.cpp b/src/codec/SkBmpCodec.cpp

index 4e801f0be198e95c9f587b42ebb1e4fe03194ecc..4ae57c057ab2d7c51d698e565be12a1c224560f7 100644

--- a/src/codec/SkBmpCodec.cpp

+++ b/src/codec/SkBmpCodec.cpp

@@ -576,9 +576,6 @@ uint32_t SkBmpCodec::computeNumColors(uint32_t numColors) {

SkCodec::Result SkBmpCodec::onStartScanlineDecode(const SkImageInfo& dstInfo,

const SkCodec::Options& options, SkPMColor inputColorPtr[], int* inputColorCount) {

- if (!this->rewindIfNeeded()) {

- return kCouldNotRewind;

- }

if (options.fSubset) {

// Subsets are not supported.

return kUnimplemented;

« no previous file with comments | « include/codec/SkCodec.h ('k') | src/codec/SkBmpMaskCodec.cpp » ('j') | no next file with comments »