Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3075)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1381473003: Revert of [GN]: BUILD file housecleaning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert DEPS as well Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/BUILD.gn ('k') | build/config/mac/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 1a7b68bbe59abd6a55fcb37cf5d3bc4b704af7ce..4fc8b8d1f27f1b6941763c8704e7c904e637d129 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -93,7 +93,6 @@ config("default_include_dirs") {
# where stuff should go. Put warning related stuff in the "warnings" config.
config("compiler") {
- asmflags = []
cflags = []
cflags_c = []
cflags_cc = []
@@ -457,20 +456,11 @@ config("compiler") {
# Pass the same C/C++ flags to the objective C/C++ compiler.
cflags_objc += cflags_c
cflags_objcc += cflags_cc
-
- # Assign any flags set for the C compiler to asmflags so that they are sent
- # to the assembler. The Windows assembler takes different types of flags
- # so only do so for posix platforms.
- if (is_posix) {
- asmflags += cflags
- asmflags += cflags_c
- }
}
config("compiler_arm_fpu") {
if (current_cpu == "arm" && !is_ios && !is_nacl) {
cflags = [ "-mfpu=$arm_fpu" ]
- asmflags = cflags
}
}
@@ -819,7 +809,6 @@ config("no_chromium_code") {
"-Wno-deprecated",
]
}
-
cflags += default_warning_flags
cflags_cc += default_warning_flags_cc
}
@@ -1097,7 +1086,6 @@ config("symbols") {
if (use_debug_fission) {
cflags += [ "-gsplit-dwarf" ]
}
- asmflags = cflags
ldflags = []
}
}
@@ -1120,7 +1108,6 @@ config("minimal_symbols") {
if (use_debug_fission) {
cflags += [ "-gsplit-dwarf" ]
}
- asmflags = cflags
ldflags = []
}
}
@@ -1129,7 +1116,6 @@ config("minimal_symbols") {
config("no_symbols") {
if (!is_win) {
cflags = [ "-g0" ]
- asmflags = cflags
}
}
« no previous file with comments | « build/config/android/BUILD.gn ('k') | build/config/mac/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698