Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/BUILD.gn

Issue 1381473003: Revert of [GN]: BUILD file housecleaning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert DEPS as well Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | build/config/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index c8da546781c29aa77d296cb2e5c3c9e69b32845e..f7c52f8ad9a7c67f5397950aa426f44ce4140eed 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -449,7 +449,9 @@ config("precompiled_headers") {
# then delete the precompile.c.obj file, then build again.
cflags_c = [ "/wd4206" ]
} else if (is_mac && !is_official_build && !use_goma) {
- precompiled_header = "build/precompile.h"
- precompiled_source = "//build/precompile.h"
+ # TODO(andybons): enable this when GCC PCH support in the binary has been
+ # rolled.
+ #precompiled_header = "build/precompile.h"
+ #precompiled_source = "//build/precompile.h"
}
}
« no previous file with comments | « DEPS ('k') | build/config/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698