Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1381463002: Added LayerAnimationObserver::OnLayerAnimationStarted() notification. (Closed)

Created:
5 years, 2 months ago by bruthig
Modified:
5 years, 2 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added an OnLayerAnimationStarted() notification to the LayerAnimationObserver. BUG=522175, 537614 TEST=LayerAnimatorObserverNotificationOrderTest.SuccessfulCompletionOfSequence TEST=LayerAnimatorObserverNotificationOrderTest.AbortingAScheduledSequence TEST=LayerAnimatorObserverNotificationOrderTest.RunningASequenceThatIsQueuedForLaterStartTime TEST=LayerAnimatorObserverNotificationOrderTest.RunningASequenceThatPreEmptsAnotherSequence Committed: https://crrev.com/c6e5c539b545cb115d23a05016f19dcb71a03ea7 Cr-Commit-Position: refs/heads/master@{#352936}

Patch Set 1 #

Patch Set 2 : Added tests. #

Patch Set 3 : Polish after self review. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+605 lines, -184 lines) Patch
M ui/compositor/layer_animation_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/compositor/layer_animation_observer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/compositor/layer_animation_sequence.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/compositor/layer_animation_sequence.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/compositor/layer_animator_unittest.cc View 1 2 52 chunks +320 lines, -168 lines 0 comments Download
M ui/compositor/test/test_layer_animation_observer.h View 1 2 2 chunks +84 lines, -7 lines 0 comments Download
M ui/compositor/test/test_layer_animation_observer.cc View 1 2 2 chunks +185 lines, -9 lines 1 comment Download

Messages

Total messages: 16 (5 generated)
bruthig
5 years, 2 months ago (2015-09-29 17:03:26 UTC) #2
Ian Vollick
On 2015/09/29 17:03:26, bruthig wrote: looks great, but needs a test.
5 years, 2 months ago (2015-09-30 21:16:00 UTC) #3
bruthig
On 2015/09/30 21:16:00, vollick wrote: > On 2015/09/29 17:03:26, bruthig wrote: > > looks great, ...
5 years, 2 months ago (2015-10-01 22:44:02 UTC) #4
danakj
+ajuma
5 years, 2 months ago (2015-10-07 15:51:39 UTC) #6
ajuma
lgtm. Those tests look great, thanks for adding them!
5 years, 2 months ago (2015-10-07 17:17:51 UTC) #7
Ian Vollick
lgtm, too. https://codereview.chromium.org/1381463002/diff/40001/ui/compositor/test/test_layer_animation_observer.cc File ui/compositor/test/test_layer_animation_observer.cc (right): https://codereview.chromium.org/1381463002/diff/40001/ui/compositor/test/test_layer_animation_observer.cc#newcode97 ui/compositor/test/test_layer_animation_observer.cc:97: << last_attached_sequence_; This is so cool.
5 years, 2 months ago (2015-10-07 17:52:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381463002/40001
5 years, 2 months ago (2015-10-07 17:54:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/114262)
5 years, 2 months ago (2015-10-07 19:28:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381463002/40001
5 years, 2 months ago (2015-10-07 19:53:49 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-07 20:44:29 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 20:45:33 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c6e5c539b545cb115d23a05016f19dcb71a03ea7
Cr-Commit-Position: refs/heads/master@{#352936}

Powered by Google App Engine
This is Rietveld 408576698