Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 1381443003: Disable support for swapped out RenderFrame(Host) (Closed)

Created:
5 years, 2 months ago by nasko
Modified:
5 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable support for swapped out RenderFrame(Host) Another attempt at disabling swapped out. The crashes and bugs found during the first attempt should be fixed now. BUG=357747 Committed: https://crrev.com/aa836bae06656808d56e0afde4944b6dcca97a10 Cr-Commit-Position: refs/heads/master@{#353055}

Patch Set 1 #

Patch Set 2 : Fix crashing on window access after forward/back navigation. #

Total comments: 4

Patch Set 3 : Rebase to pick up fixes. #

Patch Set 4 : Change TextAutosizer to not use page(). #

Patch Set 5 : Better fix for autosizer. #

Patch Set 6 : Rebase to pick up TextAutosizer fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/site_isolation_policy.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
nasko
Hey Charlie, Can you take a look at this fix? The CL probably needs a ...
5 years, 2 months ago (2015-09-30 19:22:03 UTC) #2
Charlie Reis
Great. Mostly nits and clarifying questions. https://chromiumcodereview.appspot.com/1381443003/diff/20001/content/browser/frame_host/render_frame_host_manager.cc File content/browser/frame_host/render_frame_host_manager.cc (right): https://chromiumcodereview.appspot.com/1381443003/diff/20001/content/browser/frame_host/render_frame_host_manager.cc#newcode917 content/browser/frame_host/render_frame_host_manager.cc:917: // reuse it. ...
5 years, 2 months ago (2015-09-30 21:08:04 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381443003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381443003/120001
5 years, 2 months ago (2015-10-03 16:52:06 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-03 18:20:21 UTC) #8
Charlie Reis
Exciting! LGTM once Alex's CL lands.
5 years, 2 months ago (2015-10-07 20:03:21 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381443003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381443003/120001
5 years, 2 months ago (2015-10-08 04:10:35 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/64227)
5 years, 2 months ago (2015-10-08 04:34:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381443003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381443003/120001
5 years, 2 months ago (2015-10-08 13:54:00 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 2 months ago (2015-10-08 14:30:55 UTC) #16
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/aa836bae06656808d56e0afde4944b6dcca97a10 Cr-Commit-Position: refs/heads/master@{#353055}
5 years, 2 months ago (2015-10-08 14:31:31 UTC) #17
nasko
5 years, 2 months ago (2015-10-10 00:25:11 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:120001) has been created in
https://codereview.chromium.org/1394373003/ by nasko@chromium.org.

The reason for reverting is: Speculative revert to see if crashes hit in
crbug.com/541578 will disappear..

Powered by Google App Engine
This is Rietveld 408576698