Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 138143020: Revert 245684 "[telemetry] bitmaptools as a standalone executable" (Closed)

Created:
6 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 11 months ago
Reviewers:
szym
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 245684 "[telemetry] bitmaptools as a standalone executable" Broke gpu_tests step on Android Debug GPU bot; see crbug.com/323813 for details. > [telemetry] bitmaptools as a standalone executable > > The C++ binary implements simple per-pixel algorithms for SpeedIndex > computation. This allows us to achieve near real-time processing without > bringing external dependencies. > > The bitmaptools binary needs to be built before it can be used. > The overhead of spawning a child process for each frame is about 3ms. > > BUG=323813 > TEST=telemetry bitmap_unittest > > Review URL: https://codereview.chromium.org/136793022 TBR=szym@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -386 lines) Patch
M trunk/src/PRESUBMIT.py View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/build/all.gyp View 4 chunks +0 lines, -4 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry.gyp View 1 chunk +0 lines, -15 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/core/bitmap.py View 7 chunks +46 lines, -94 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/core/bitmap_unittest.py View 7 chunks +5 lines, -7 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/core/bitmaptools.cc View 1 chunk +0 lines, -264 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ken Russell (switch to Gerrit)
6 years, 11 months ago (2014-01-18 01:55:45 UTC) #1
Ken Russell (switch to Gerrit)
6 years, 11 months ago (2014-01-18 01:55:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r245712.

Powered by Google App Engine
This is Rietveld 408576698