Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 138143019: Drop warnings from adb shell output (Closed)

Created:
6 years, 11 months ago by kbalazs
Modified:
6 years, 10 months ago
Reviewers:
craigdh
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Drop warnings from adb shell output This is a quick and dirty fix for a problem that occurs to me when trying to run instrumentation tests in a simulator. For some reason 'pm path org.chromium.content_shell_apk.tests' outputs a warning message in my environment that confuses the python scripts and they end up calling md5sum for the root directory which is a bit slow... The real fix would be to be able drop the stderr of the command but it needs a lot of plumbing and probably there is not that much chance that something like that will happen again for someone. BUG=334439 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247742

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/android/pylib/android_commands.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kbalazs
6 years, 11 months ago (2014-01-17 23:28:02 UTC) #1
craigdh
https://codereview.chromium.org/138143019/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/138143019/diff/1/build/android/pylib/android_commands.py#newcode644 build/android/pylib/android_commands.py:644: # FIXME: we should really be able to drop ...
6 years, 11 months ago (2014-01-23 21:55:36 UTC) #2
craigdh
lgtm.
6 years, 10 months ago (2014-01-28 17:26:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/138143019/60001
6 years, 10 months ago (2014-01-29 16:09:16 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253508
6 years, 10 months ago (2014-01-29 17:40:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/138143019/60001
6 years, 10 months ago (2014-01-29 18:08:57 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 21:27:37 UTC) #7
Message was sent while issue was closed.
Change committed as 247742

Powered by Google App Engine
This is Rietveld 408576698