Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 138143014: Robustified extension installation a bit. (Closed)

Created:
6 years, 11 months ago by Sven Panne
Modified:
6 years, 11 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Robustified extension installation a bit. Removed ADDRESS_SANITIZER #ifdefs, the extension is so tiny that it's not worth the clutter. R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -57 lines) Patch
M src/bootstrapper.cc View 9 chunks +60 lines, -55 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 11 months ago (2014-01-16 12:38:31 UTC) #1
dcarney
lgtm
6 years, 11 months ago (2014-01-16 13:15:06 UTC) #2
Sven Panne
6 years, 11 months ago (2014-01-16 13:18:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18645 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698