Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 138143010: Revert "[telemetry] Implement per-pixel algorithms in Bitmap as a C++ extension." (Closed)

Created:
6 years, 11 months ago by szym
Modified:
6 years, 11 months ago
Reviewers:
tonyg, M-A Ruel
CC:
chromium-reviews, chrome-speed-team+watch_google.com, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

Revert "[telemetry] Implement per-pixel algorithms in Bitmap as a C++ extension." This reverts commit 17dad9d57df1acd108e32169ffc9584988c9d9d6. Although simple in principle, the Python C extension approach does not fit the diversity of our infrastructure. We will need a better method to address the speed requirements for ColorHistogram. BUG=333606, 323813, 334097, 333361, 334523 TBR=tonyg,maruel Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -511 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/telemetry.isolate View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/telemetry/telemetry.gyp View 1 chunk +0 lines, -45 lines 0 comments Download
M tools/telemetry/telemetry/core/bitmap.py View 6 chunks +62 lines, -44 lines 0 comments Download
M tools/telemetry/telemetry/core/bitmap_unittest.py View 9 chunks +5 lines, -11 lines 0 comments Download
D tools/telemetry/telemetry/core/bitmaptools/__init__.py View 1 chunk +0 lines, -38 lines 0 comments Download
D tools/telemetry/telemetry/core/bitmaptools/bitmaptools.cc View 1 chunk +0 lines, -276 lines 0 comments Download
D tools/telemetry/telemetry/core/build_extension.py View 1 chunk +0 lines, -60 lines 0 comments Download
M tools/telemetry/telemetry/core/util.py View 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tonyg
Too bad :( Let's make sure the trybots are happy w/ this revert.
6 years, 11 months ago (2014-01-15 20:22:33 UTC) #1
szym
Since there is no easy fix, I am reverting back to old implementations. For GetBoundingBox ...
6 years, 11 months ago (2014-01-15 20:23:01 UTC) #2
M-A Ruel
lgtm, my sympathy.
6 years, 11 months ago (2014-01-15 20:24:39 UTC) #3
scottmg
"diversity" indeed! That almost makes it sound like a good thing.
6 years, 11 months ago (2014-01-15 20:33:44 UTC) #4
szym
tryserver is not picking up the jobs for some reason. I tried both git cl ...
6 years, 11 months ago (2014-01-15 21:27:00 UTC) #5
achuithb
On 2014/01/15 21:27:00, szym wrote: > tryserver is not picking up the jobs for some ...
6 years, 11 months ago (2014-01-15 21:40:23 UTC) #6
szym
On 2014/01/15 21:40:23, achuith.bhandarkar wrote: > On 2014/01/15 21:27:00, szym wrote: > > tryserver is ...
6 years, 11 months ago (2014-01-15 22:21:09 UTC) #7
tonyg
On 2014/01/15 22:21:09, szym wrote: > On 2014/01/15 21:40:23, achuith.bhandarkar wrote: > > On 2014/01/15 ...
6 years, 11 months ago (2014-01-15 22:25:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/138143010/1
6 years, 11 months ago (2014-01-15 22:52:37 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 05:39:07 UTC) #10
Message was sent while issue was closed.
Change committed as 245145

Powered by Google App Engine
This is Rietveld 408576698