Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1381423002: Reland of permissions: remove duplicates from request multiple at the Blink level (Closed)

Created:
5 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 2 months ago
Reviewers:
Lalit Maganti, dmurph
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor-permissions
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of permissions: remove duplicates from request multiple at the Blink level (patchset #1 id:1 of https://codereview.chromium.org/1381353002/ ) Reason for revert: Depending CL has relanded. Original issue's description: > Revert of permissions: remove duplicates from request multiple at the Blink level (patchset #4 id:60001 of https://codereview.chromium.org/1360023005/ ) > > Reason for revert: > BUG=538717 > > Original issue's description: > > permissions: remove duplicates from request multiple at the Blink level > > > > Propogating this information all the way to PermissionManager so it can be handled there > > seems to be a waste of time and memory. It also adds a bunch of complexity to > > all PermissionManager implementations. > > > > Instead of this, handle all duplication at the Blink level so that chrome > > can focus on handling requests. > > > > BUG=516626 > > > > Committed: https://crrev.com/b3d2e697dc79112379f96f0f34cf26b83227a737 > > Cr-Commit-Position: refs/heads/master@{#352072} > > TBR=mlamouri@chromium.org,lalitm@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=516626 > > Committed: https://crrev.com/274f94ac26b2c789770e9280295a4f7dc71a8be0 > Cr-Commit-Position: refs/heads/master@{#352113} TBR=lalitm@google.com,dmurph@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=538717 Committed: https://crrev.com/658cc2178366755f9d54267e03a241f721be1873 Cr-Commit-Position: refs/heads/master@{#352256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -19 lines) Patch
M third_party/WebKit/Source/modules/permissions/Permissions.cpp View 3 chunks +23 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/permissions/PermissionsCallback.h View 2 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/permissions/PermissionsCallback.cpp View 2 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mlamouri (slow - plz ping)
Created Reland of permissions: remove duplicates from request multiple at the Blink level
5 years, 2 months ago (2015-10-03 14:53:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381423002/1
5 years, 2 months ago (2015-10-03 14:53:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-03 14:53:37 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-03 14:54:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/658cc2178366755f9d54267e03a241f721be1873
Cr-Commit-Position: refs/heads/master@{#352256}

Powered by Google App Engine
This is Rietveld 408576698