[bindings] add support for integer-indexed @@iterator

third_party/WebKit/Source/bindings/scripts/idl_definitions.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 268 matching lines @@
         self.attributes = []
         self.constants = []
         self.constructors = []
         self.custom_constructors = []
         self.extended_attributes = {}
         self.operations = []
         self.parent = None
         self.serializer = None
         self.stringifier = None
         self.iterable = None
+        self.has_indexed_elements = False
         self.maplike = None
         self.setlike = None
         self.original_interface = None
         self.partial_interfaces = []
         if not node:  # Early exit for IdlException.__init__
             return
 
         self.is_callback = bool(node.GetProperty('CALLBACK'))
         self.is_exception = False
         # FIXME: uppercase 'Partial' => 'PARTIAL' in base IDL parser
         self.is_partial = bool(node.GetProperty('Partial'))
         self.idl_name = idl_name
         self.name = node.GetName()
         self.idl_type = IdlType(self.name)
 
+        has_indexed_property_getter = False
+        has_integer_typed_length = False
+
         children = node.GetChildren()
         for child in children:
             child_class = child.GetClass()
             if child_class == 'Attribute':
-                self.attributes.append(IdlAttribute(idl_name, child))
+                attr = IdlAttribute(idl_name, child)
+                if attr.idl_type.is_integer_type:

[Jens Widell, 2015/10/05 05:57:11]

Shouldn't we also check that the name is 'length' here?

[caitp (gmail), 2015/10/05 11:30:23]

Yes, good catch. Done

+                    has_integer_typed_length = True
+                self.attributes.append(attr)
             elif child_class == 'Const':
                 self.constants.append(IdlConstant(idl_name, child))
             elif child_class == 'ExtAttributes':
                 extended_attributes = ext_attributes_node_to_extended_attributes(idl_name, child)
                 self.constructors, self.custom_constructors = (
                     extended_attributes_to_constructors(idl_name, extended_attributes))
                 clear_constructor_attributes(extended_attributes)
                 self.extended_attributes = extended_attributes
             elif child_class == 'Operation':
-                self.operations.append(IdlOperation(idl_name, child))
+                op = IdlOperation(idl_name, child)
+                if 'getter' in op.specials and len(op.arguments) == 1 and op.arguments[0].idl_type == 'unsigned long':

[Jens Widell, 2015/10/05 05:57:11]

Checking len(op.arguments) is a bit optional here; getters can't really have
more than one argument. I think it would be fine for this code here to assume
that a getter has exactly one argument.

[caitp (gmail), 2015/10/05 11:30:23]

Done

+                    has_indexed_property_getter = True
+                self.operations.append(op)
             elif child_class == 'Inherit':
                 self.parent = child.GetName()
             elif child_class == 'Serializer':
                 self.serializer = IdlSerializer(idl_name, child)
                 self.process_serializer()
             elif child_class == 'Stringifier':
                 self.stringifier = IdlStringifier(idl_name, child)
                 self.process_stringifier()
             elif child_class == 'Iterable':
                 self.iterable = IdlIterable(idl_name, child)
             elif child_class == 'Maplike':
                 self.maplike = IdlMaplike(idl_name, child)
             elif child_class == 'Setlike':
                 self.setlike = IdlSetlike(idl_name, child)
             else:
                 raise ValueError('Unrecognized node class: %s' % child_class)
 
         if len(filter(None, [self.iterable, self.maplike, self.setlike])) > 1:
             raise ValueError('Interface can only have one of iterable<>, maplike<> and setlike<>.')
 
+        if has_integer_typed_length and has_indexed_property_getter:
+            self.has_indexed_elements = True
+
     def accept(self, visitor):
         visitor.visit_interface(self)
         for attribute in self.attributes:
             attribute.accept(visitor)
         for constant in self.constants:
             constant.accept(visitor)
         for constructor in self.constructors:
             constructor.accept(visitor)
         for custom_constructor in self.custom_constructors:
             custom_constructor.accept(visitor)
@@ skipping 739 matching lines @@
         self.visit_typed_object(argument)
 
     def visit_iterable(self, iterable):
         self.visit_typed_object(iterable)
 
     def visit_maplike(self, maplike):
         self.visit_typed_object(maplike)
 
     def visit_setlike(self, setlike):
         self.visit_typed_object(setlike)