Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 13814023: Run mixedxfermodes GM through the pipe. (Closed)

Created:
7 years, 8 months ago by scroggo
Modified:
7 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Run mixedxfermodes GM through the pipe. Pass the size of the GM to SkGPipeWriter.startRecording(), so that calls to getDeviceSize() on the returned SkCanvas return a reasonable result. This allows removing the flag to skip mixedxfermodes. BUG=https://code.google.com/p/skia/issues/detail?id=1199 Committed: https://code.google.com/p/skia/source/detail?r=8598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M gm/gmmain.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M gm/mixedxfermodes.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
7 years, 8 months ago (2013-04-10 15:03:38 UTC) #1
bsalomon
On 2013/04/10 15:03:38, scroggo wrote: lgtm
7 years, 8 months ago (2013-04-10 15:21:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/13814023/1
7 years, 8 months ago (2013-04-10 16:43:06 UTC) #3
commit-bot: I haz the power
Failed to apply patch for gm/gmmain.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 8 months ago (2013-04-10 16:43:07 UTC) #4
scroggo
7 years, 8 months ago (2013-04-10 18:10:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r8598 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698