Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Issue 13814015: Reland of 8525 with fix for case when GrRT outlives GrTexture. (Closed)

Created:
7 years, 8 months ago by bsalomon
Modified:
7 years, 8 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Reland of 8525 with fix for case when GrRT outlives GrTexture. Committed: https://code.google.com/p/skia/source/detail?r=8573

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -47 lines) Patch
M gyp/tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrRenderTarget.h View 1 chunk +7 lines, -11 lines 2 comments Download
M include/gpu/GrSurface.h View 1 chunk +16 lines, -0 lines 0 comments Download
M include/gpu/GrTexture.h View 5 chunks +7 lines, -13 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrTexture.cpp View 2 chunks +7 lines, -19 lines 1 comment Download
M src/gpu/gl/GrGLTexture.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + tests/GrSurfaceTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Take 2 at the isSameAs() change. The two new diff blocks are noted. https://codereview.chromium.org/13814015/diff/1/include/gpu/GrRenderTarget.h File ...
7 years, 8 months ago (2013-04-09 13:38:26 UTC) #1
robertphillips
lgtm
7 years, 8 months ago (2013-04-09 13:45:12 UTC) #2
bsalomon
7 years, 8 months ago (2013-04-09 15:04:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r8573 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698