verification/fake.py - Issue 138133014: Revert of CQ to always post a message when Commit box is unchecked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: verification/fake.py

Issue 138133014: Revert of CQ to always post a message when Commit box is unchecked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: verification/fake.py

diff --git a/verification/fake.py b/verification/fake.py

index 9b95854c46c876d7a1d84e851eb3819de87a9c92..c38009e3de161acaedcf9f1ba07ec2e12016d73b 100644

--- a/verification/fake.py

+++ b/verification/fake.py

@@ -6,8 +6,6 @@

from verification import base

-def failed_message():

- return 'FakeVerifier FAILED'

class FakeVerifier(base.Verifier):

name = 'fake'

@@ -17,11 +15,7 @@

self.state = state

def verify(self, pending):

- fake = base.SimpleStatus(self.state)

- # Make sure to leave a message, so CQ tests can reliably test for it.

- if self.state == base.FAILED:

- fake.error_message = failed_message()

- pending.verifications[self.name] = fake

+ pending.verifications[self.name] = base.SimpleStatus(self.state)

def update_status(self, queue):

pass

@@ -45,6 +39,3 @@

for _, fake in self.loop(queue, base.SimpleStatus, True):

fake.state = self.state

- # Make sure to leave a message, so CQ tests can reliably test for it.

- if self.state == base.FAILED:

- fake.error_message = failed_message()

« no previous file with comments | « tests/pending_manager_test.py ('k') | no next file » | no next file with comments »