Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 138133014: Revert of CQ to always post a message when Commit box is unchecked. (Closed)

Created:
5 years, 5 months ago by Sergey Berezin
Modified:
5 years, 5 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Revert of CQ to always post a message when Commit box is unchecked. (https://codereview.chromium.org/138173005/) Reason for revert: This created a lot of spam at commit event for some obscure reason. I couldn't fix it fast, so reverting. Original issue's description: > Made _discard_pending() always post a message. Added meaningful > default messages to all the places where it is called in the code. In > particular, CQ will now always post a message whenever the Commit > checkbox is unchecked, for any reason. > > Updated unit tests accordingly, and made them a bit more robust by > adding an error message to the failing FakeVerifier. > > This does NOT fix the bug, but will hopefully give more visibility to > developers when a CL is dropped. > > BUG=238283 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=247488 TBR=phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true BUG=238283 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=248624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -55 lines) Patch
M pending_manager.py View 8 chunks +28 lines, -38 lines 0 comments Download
M tests/pending_manager_test.py View 5 chunks +5 lines, -7 lines 0 comments Download
M verification/fake.py View 3 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Sergey Berezin
Created Revert of CQ to always post a message when Commit box is unchecked.
5 years, 5 months ago (2014-02-04 00:06:05 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
5 years, 5 months ago (2014-02-04 00:06:08 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2014-02-04 00:06:09 UTC) #3
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
5 years, 5 months ago (2014-02-04 00:06:17 UTC) #4
Paweł Hajdan Jr.
LGTM
5 years, 5 months ago (2014-02-04 00:08:37 UTC) #5
Sergey Berezin
The CQ bit was checked by sergeyberezin@chromium.org
5 years, 5 months ago (2014-02-04 00:10:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyberezin@chromium.org/138133014/1
5 years, 5 months ago (2014-02-04 00:10:14 UTC) #7
commit-bot: I haz the power
Change committed as 248624
5 years, 5 months ago (2014-02-04 00:10:46 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
5 years, 5 months ago (2014-02-04 00:10:50 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
5 years, 5 months ago (2014-02-04 00:10:51 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
5 years, 5 months ago (2014-02-04 00:10:52 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
5 years, 5 months ago (2014-02-04 00:10:53 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2014-02-04 00:14:24 UTC) #13
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698