Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: media/filters/video_decoder_selector_unittest.cc

Issue 13813016: Remove reference counting from media::Demuxer and friends. (Closed) Base URL: http://git.chromium.org/chromium/src.git@vd_scoped
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/video_decoder_selector_unittest.cc
diff --git a/media/filters/video_decoder_selector_unittest.cc b/media/filters/video_decoder_selector_unittest.cc
index 764a0ba00327f0e99e75bc5a3ce07da035041bb2..bca0da791526d3bff910ddbb6bb07ff98f3eb353 100644
--- a/media/filters/video_decoder_selector_unittest.cc
+++ b/media/filters/video_decoder_selector_unittest.cc
@@ -9,6 +9,7 @@
#include "media/base/gmock_callback_support.h"
#include "media/base/mock_filters.h"
#include "media/base/test_helpers.h"
+#include "media/filters/decrypting_demuxer_stream.h"
#include "media/filters/video_decoder_selector.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -69,13 +70,12 @@ class VideoDecoderSelectorTest : public ::testing::Test {
MOCK_METHOD1(OnStatistics, void(const PipelineStatistics&));
MOCK_METHOD1(SetDecryptorReadyCallback, void(const media::DecryptorReadyCB&));
MOCK_METHOD2(OnDecoderSelected,
- void(VideoDecoder*,
- const scoped_refptr<DecryptingDemuxerStream>&));
+ void(VideoDecoder*, DecryptingDemuxerStream*));
void MockOnDecoderSelected(
scoped_ptr<VideoDecoder> decoder,
- const scoped_refptr<DecryptingDemuxerStream>& stream) {
- OnDecoderSelected(decoder.get(), stream);
+ scoped_ptr<DecryptingDemuxerStream> stream) {
+ OnDecoderSelected(decoder.get(), stream.get());
selected_decoder_ = decoder.Pass();
}
@@ -122,7 +122,7 @@ class VideoDecoderSelectorTest : public ::testing::Test {
void SelectDecoder() {
decoder_selector_->SelectVideoDecoder(
- demuxer_stream_,
+ demuxer_stream_.get(),
base::Bind(&VideoDecoderSelectorTest::OnStatistics,
base::Unretained(this)),
base::Bind(&VideoDecoderSelectorTest::MockOnDecoderSelected,
@@ -134,7 +134,7 @@ class VideoDecoderSelectorTest : public ::testing::Test {
scoped_ptr<VideoDecoderSelector> decoder_selector_;
VideoDecoderConfig clear_video_config_;
VideoDecoderConfig encrypted_video_config_;
- scoped_refptr<StrictMock<MockDemuxerStream> > demuxer_stream_;
+ scoped_ptr<StrictMock<MockDemuxerStream> > demuxer_stream_;
// Use NiceMock since we don't care about most of calls on the decryptor, e.g.
// RegisterNewKeyCB().
scoped_ptr<NiceMock<MockDecryptor> > decryptor_;

Powered by Google App Engine
This is Rietveld 408576698