Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: media/filters/chunk_demuxer.h

Issue 13813016: Remove reference counting from media::Demuxer and friends. (Closed) Base URL: http://git.chromium.org/chromium/src.git@vd_scoped
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/chunk_demuxer.h
diff --git a/media/filters/chunk_demuxer.h b/media/filters/chunk_demuxer.h
index 94c952ea6e439fec4aa8c587d14705e3645045aa..3433922ba18e3b2ce7ec145c66a8aacc19db529e 100644
--- a/media/filters/chunk_demuxer.h
+++ b/media/filters/chunk_demuxer.h
@@ -45,6 +45,7 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
// console.
ChunkDemuxer(const base::Closure& open_cb, const NeedKeyCB& need_key_cb,
const LogCB& log_cb);
+ virtual ~ChunkDemuxer();
// Demuxer implementation.
virtual void Initialize(DemuxerHost* host,
@@ -52,8 +53,7 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
virtual void Stop(const base::Closure& callback) OVERRIDE;
virtual void Seek(base::TimeDelta time, const PipelineStatusCB& cb) OVERRIDE;
virtual void OnAudioRendererDisabled() OVERRIDE;
- virtual scoped_refptr<DemuxerStream> GetStream(
- DemuxerStream::Type type) OVERRIDE;
+ virtual DemuxerStream* GetStream(DemuxerStream::Type type) OVERRIDE;
virtual base::TimeDelta GetStartTime() const OVERRIDE;
// Methods used by an external object to control this demuxer.
@@ -104,9 +104,6 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
bool EndOfStream(PipelineStatus status);
void Shutdown();
- protected:
- virtual ~ChunkDemuxer();
-
private:
enum State {
WAITING_FOR_INIT,
@@ -159,7 +156,7 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
// |stream|.
void IncreaseDurationIfNecessary(
const StreamParser::BufferQueue& buffers,
- const scoped_refptr<ChunkDemuxerStream>& stream);
+ ChunkDemuxerStream* stream);
// Decreases |duration_| if the buffered region is less than |duration_| when
// EndOfStream() is called.
@@ -185,8 +182,8 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
PipelineStatusCB init_cb_;
PipelineStatusCB seek_cb_;
- scoped_refptr<ChunkDemuxerStream> audio_;
- scoped_refptr<ChunkDemuxerStream> video_;
+ scoped_ptr<ChunkDemuxerStream> audio_;
+ scoped_ptr<ChunkDemuxerStream> video_;
base::TimeDelta duration_;

Powered by Google App Engine
This is Rietveld 408576698