Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: media/base/pipeline.h

Issue 13813016: Remove reference counting from media::Demuxer and friends. (Closed) Base URL: http://git.chromium.org/chromium/src.git@vd_scoped
Patch Set: demuxer only Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/pipeline.h
diff --git a/media/base/pipeline.h b/media/base/pipeline.h
index efd327d445270e01a5c6c9444ad6978c0dec8c9e..34e36f0ad2d4ee4bda3445b76b760b260b7f352b 100644
--- a/media/base/pipeline.h
+++ b/media/base/pipeline.h
@@ -442,8 +442,6 @@ class MEDIA_EXPORT Pipeline
// Set to true in DisableAudioRendererTask().
bool audio_disabled_;
- scoped_ptr<FilterCollection> filter_collection_;
-
// Temporary callback used for Start() and Seek().
PipelineStatusCB seek_cb_;
@@ -456,14 +454,17 @@ class MEDIA_EXPORT Pipeline
BufferingStateCB buffering_state_cb_;
base::Closure duration_change_cb_;
- // Renderer references used for setting the volume, playback rate, and
- // determining when playback has finished.
+ // Contains the demuxer and renderers to use when initializing.
+ scoped_ptr<FilterCollection> filter_collection_;
+
+ // Holds the initialized demuxer. Used for seeking. Owned by client.
+ Demuxer* demuxer_;
+
+ // Holds the initialized renderers. Used for setting the volume,
+ // playback rate, and determining when playback has finished.
scoped_ptr<AudioRenderer> audio_renderer_;
scoped_ptr<VideoRenderer> video_renderer_;
- // Demuxer reference used for setting the preload value.
- scoped_refptr<Demuxer> demuxer_;
-
PipelineStatistics statistics_;
// Time of pipeline creation; is non-zero only until the pipeline first
« no previous file with comments | « media/base/mock_filters.h ('k') | media/base/pipeline.cc » ('j') | media/base/pipeline.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698