Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: media/tools/demuxer_bench/demuxer_bench.cc

Issue 13813016: Remove reference counting from media::Demuxer and friends. (Closed) Base URL: http://git.chromium.org/chromium/src.git@vd_scoped
Patch Set: fix tools Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/tools/demuxer_bench/demuxer_bench.cc
diff --git a/media/tools/demuxer_bench/demuxer_bench.cc b/media/tools/demuxer_bench/demuxer_bench.cc
index 78216958f0c5dca6a3a5e8224c432af82c01bd3d..40b79b23364b38afa00142c914ccc718c77e4c03 100644
--- a/media/tools/demuxer_bench/demuxer_bench.cc
+++ b/media/tools/demuxer_bench/demuxer_bench.cc
@@ -54,7 +54,7 @@ typedef std::vector<scoped_refptr<media::DemuxerStream> > Streams;
// present in |demuxer| in as-close-to-monotonically-increasing timestamp order.
class StreamReader {
public:
- explicit StreamReader(const scoped_refptr<media::Demuxer>& demuxer);
+ explicit StreamReader(media::Demuxer* demuxer);
~StreamReader();
// Performs a single step read.
@@ -83,7 +83,7 @@ class StreamReader {
DISALLOW_COPY_AND_ASSIGN(StreamReader);
};
-StreamReader::StreamReader(const scoped_refptr<media::Demuxer> &demuxer) {
+StreamReader::StreamReader(media::Demuxer* demuxer) {
scoped_refptr<media::DemuxerStream> stream;
stream = demuxer->GetStream(media::DemuxerStream::AUDIO);
if (stream) {
@@ -183,15 +183,14 @@ int main(int argc, char** argv) {
CHECK(data_source->Initialize(file_path));
media::FFmpegNeedKeyCB need_key_cb = base::Bind(&NeedKey);
- scoped_refptr<media::FFmpegDemuxer> demuxer =
- new media::FFmpegDemuxer(message_loop.message_loop_proxy(), data_source,
- need_key_cb);
+ scoped_ptr<media::FFmpegDemuxer> demuxer(new media::FFmpegDemuxer(
+ message_loop.message_loop_proxy(), data_source, need_key_cb));
demuxer->Initialize(&demuxer_host, base::Bind(
&QuitLoopWithStatus, &message_loop));
message_loop.Run();
- StreamReader stream_reader(demuxer);
+ StreamReader stream_reader(demuxer.get());
// Benchmark.
base::TimeTicks start = base::TimeTicks::HighResNow();

Powered by Google App Engine
This is Rietveld 408576698