Separate Simple Backend creation from initialization.

net/disk_cache/simple/simple_backend_impl.h

Index: net/disk_cache/simple/simple_backend_impl.h
diff --git a/net/disk_cache/simple/simple_backend_impl.h b/net/disk_cache/simple/simple_backend_impl.h
index 99a01d8f9f862d6a50ed2d3ea2074d0ffdf62d76..4981ce7b2a8e0c82a88375099721161f8aabc038 100644
--- a/net/disk_cache/simple/simple_backend_impl.h
+++ b/net/disk_cache/simple/simple_backend_impl.h
@@ -29,16 +29,12 @@ class SimpleIndex;
 
 class NET_EXPORT_PRIVATE SimpleBackendImpl : public Backend {
  public:
-  virtual ~SimpleBackendImpl();
+  SimpleBackendImpl(const base::FilePath& path, int max_bytes,
+                    net::CacheType type,
+                    const scoped_refptr<base::TaskRunner>& cache_thread,
+                    net::NetLog* net_log);
 
-  static int CreateBackend(const base::FilePath& full_path,
-                           int max_bytes,
-                           net::CacheType type,
-                           uint32 flags,
-                           scoped_refptr<base::TaskRunner> cache_thread,
-                           net::NetLog* net_log,
-                           Backend** backend,
-                           const CompletionCallback& callback);
+  int Init(const CompletionCallback& callback);
 
   // From Backend:
   virtual net::CacheType GetCacheType() const OVERRIDE;
@@ -63,25 +59,16 @@ class NET_EXPORT_PRIVATE SimpleBackendImpl : public Backend {
   virtual void OnExternalCacheHit(const std::string& key) OVERRIDE;
 
  private:
-  SimpleBackendImpl(
-      const scoped_refptr<base::TaskRunner>& cache_thread,
-      const base::FilePath& path);
-
-  // Creates the Cache directory if needed. Performs blocking IO, so it cannot
-  // be called on IO thread.
-  static void EnsureCachePathExists(
-      const base::FilePath& path,
-      const scoped_refptr<base::TaskRunner>& cache_thread,
-      const scoped_refptr<base::TaskRunner>& io_thread,
-      const CompletionCallback& callback,
-      Backend** backend);
+  virtual ~SimpleBackendImpl();

[gavinp, 2013/04/09 16:03:49]

This is weird: why redeclare the destructor as private in a subclass, but leave
the rest of the PVC public?

[pasko-google - do not use, 2013/04/09 16:20:48]

Moved back.

 
   // Must run on Cache Thread.
-  void Initialize();
+  void InitializeIndex(base::MessageLoopProxy* io_thread,
+                       const CompletionCallback& callback);
 
   const base::FilePath path_;
 
   scoped_ptr<SimpleIndex> index_;
+  const scoped_refptr<base::TaskRunner> cache_thread_;
 };
 
 }  // namespace disk_cache