Issue 13813004: Add new overlay for v1 apps in the launcher.

Issue 13813004: Add new overlay for v1 apps in the launcher. (Closed)

Created:
7 years, 8 months ago by koz (OOO until 15th September)

Modified:
7 years, 8 months ago

Reviewers:
xiyuan, oshima

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Aaron Boodman, tfarina, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, oshima

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add new overlay for v1 apps in the launcher. BUG=225975 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194487

Patch Set 4 : respond to comments #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -44 lines)			Patch
	M	chrome/app/theme/theme_resources.grd	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/app_list/extension_app_item.cc	View	1 2 3	4 chunks	+17 lines, -43 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

koz (OOO until 15th September)

Images for this are added in https://codereview.chromium.org/13812012/

7 years, 8 months ago (2013-04-09 17:56:45 UTC) #1

xiyuan

LGTM https://codereview.chromium.org/13813004/diff/5003/chrome/browser/ui/app_list/extension_app_item.cc File chrome/browser/ui/app_list/extension_app_item.cc (right): https://codereview.chromium.org/13813004/diff/5003/chrome/browser/ui/app_list/extension_app_item.cc#newcode302 chrome/browser/ui/app_list/extension_app_item.cc:302: int icon_size = extension_misc::EXTENSION_ICON_MEDIUM; nit: get rid of ...

7 years, 8 months ago (2013-04-09 18:06:26 UTC) #2

koz (OOO until 15th September)

Thanks! https://codereview.chromium.org/13813004/diff/5003/chrome/browser/ui/app_list/extension_app_item.cc File chrome/browser/ui/app_list/extension_app_item.cc (right): https://codereview.chromium.org/13813004/diff/5003/chrome/browser/ui/app_list/extension_app_item.cc#newcode302 chrome/browser/ui/app_list/extension_app_item.cc:302: int icon_size = extension_misc::EXTENSION_ICON_MEDIUM; On 2013/04/09 18:06:27, xiyuan ...

7 years, 8 months ago (2013-04-09 18:09:32 UTC) #3

koz (OOO until 15th September)

+TBR=oshima@ for chrome/app/theme/theme_resources.grd

7 years, 8 months ago (2013-04-16 23:45:43 UTC) #4

koz (OOO until 15th September)

Committed patchset #4 manually as r194487 (presubmit successful).

7 years, 8 months ago (2013-04-16 23:55:12 UTC) #5

Message was sent while issue was closed.

chrome/app/them lgtm

Expand Messages | Collapse Messages