Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 13813003: Add support for JUnit compatible XML output in the new test runner. (Closed)

Created:
7 years, 8 months ago by palfia
Modified:
7 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add support for JUnit compatible XML output in the new test runner. Implement a new output method in run-tests.py which outputs JUnit compatible XML status information. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14217

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -0 lines) Patch
M tools/run-tests.py View 2 chunks +7 lines, -0 lines 0 comments Download
A tools/testrunner/local/junit_output.py View 1 chunk +49 lines, -0 lines 0 comments Download
M tools/testrunner/local/progress.py View 1 2 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jakob Kummerow
LGTM with a few minor comments. https://codereview.chromium.org/13813003/diff/1/tools/testrunner/local/junit_output.py File tools/testrunner/local/junit_output.py (right): https://codereview.chromium.org/13813003/diff/1/tools/testrunner/local/junit_output.py#newcode32 tools/testrunner/local/junit_output.py:32: class JUnitTestOutput: nit: ...
7 years, 8 months ago (2013-04-09 09:41:35 UTC) #1
palfia
Thanks for the comments, I fixed the nits. https://codereview.chromium.org/13813003/diff/1/tools/testrunner/local/junit_output.py File tools/testrunner/local/junit_output.py (right): https://codereview.chromium.org/13813003/diff/1/tools/testrunner/local/junit_output.py#newcode32 tools/testrunner/local/junit_output.py:32: class ...
7 years, 8 months ago (2013-04-10 17:23:32 UTC) #2
Jakob Kummerow
lgtm
7 years, 8 months ago (2013-04-10 21:08:39 UTC) #3
palfia
Committed manually as r14217 (presubmit successful).
7 years, 8 months ago (2013-04-11 00:22:40 UTC) #4
Prashanth Srinivasan
7 years, 8 months ago (2013-04-16 21:09:51 UTC) #5
Message was sent while issue was closed.
On 2013/04/11 00:22:40, palfia wrote:
> Committed manually as r14217 (presubmit successful).

Is there a plan to include skipped tests as a part of JUnit compatible XML
output?

Powered by Google App Engine
This is Rietveld 408576698