A better idle time estimator

components/scheduler/renderer/idle_time_estimator.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/scheduler/renderer/idle_time_estimator.h"
+
+#include "base/time/default_tick_clock.h"
+
+namespace scheduler {
+
+IdleTimeEstimator::IdleTimeEstimator(
+    const scoped_refptr<TaskQueue>& compositor_task_runner,
+    int sample_count,
+    double estimation_percentile)
+    : compositor_task_runner_(compositor_task_runner),
+      per_frame_compositor_task_runtime_(sample_count),
+      time_source_(new base::DefaultTickClock),
+      estimation_percentile_(estimation_percentile),
+      did_commit_(false) {
+  compositor_task_runner_->AddTaskObserver(this);
+}
+
+IdleTimeEstimator::~IdleTimeEstimator() {
+  compositor_task_runner_->RemoveTaskObserver(this);
+}
+
+base::TimeDelta IdleTimeEstimator::GetExpectedIdleDuration(
+    base::TimeDelta compositor_frame_interval) const {
+  base::TimeDelta expected_compositor_task_runtime_ =
+      per_frame_compositor_task_runtime_.Percentile(estimation_percentile_);
+  return std::max(base::TimeDelta(), compositor_frame_interval -
+                                         expected_compositor_task_runtime_);
+}
+
+void IdleTimeEstimator::DidCommitFrameToCompositor() {
+  // This will run inside of a WillProcessTask / DidProcessTask pair, let
+  // DidProcessTask know a frame was comitted.
+  did_commit_ = true;
+}
+
+void IdleTimeEstimator::Clear() {
+  task_start_time_ = base::TimeTicks();
+  prev_commit_time_ = base::TimeTicks();
+  cumulative_compositor_runtime_ = base::TimeDelta();
+  per_frame_compositor_task_runtime_.Clear();
+  did_commit_ = false;
+}
+
+void IdleTimeEstimator::SetTimeSourceForTesting(
+    scoped_ptr<base::TickClock> time_source) {
+  time_source_ = time_source.Pass();
+}
+
+void IdleTimeEstimator::WillProcessTask(const base::PendingTask& pending_task) {
+  task_start_time_ = time_source_->NowTicks();

[Sami, 2015/10/15 14:43:04]

By the way we now have thread time support on all platforms, but perhaps we
still want to keep this wall clock based to account for thread contention?

[alex clarke (OOO till 29th), 2015/10/15 16:07:52]

Yeah I think that would be best.

+}
+
+void IdleTimeEstimator::DidProcessTask(const base::PendingTask& pending_task) {
+  cumulative_compositor_runtime_ += time_source_->NowTicks() - task_start_time_;

[Sami, 2015/10/15 14:43:04]

Could you add a DCHECK() here that we're not running nested tasks in the
compositor task runner since this will get confused if we are?

[alex clarke (OOO till 29th), 2015/10/15 16:07:52]

Done.

+
+  if (did_commit_) {
+    per_frame_compositor_task_runtime_.InsertSample(
+        cumulative_compositor_runtime_);
+    cumulative_compositor_runtime_ = base::TimeDelta();
+    did_commit_ = false;
+  }
+}
+
+}  // namespace scheduler