Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Side by Side Diff: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Issue 1381273002: A better idle time estimator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/renderer/renderer_scheduler_impl.h" 5 #include "components/scheduler/renderer/renderer_scheduler_impl.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/test/simple_test_tick_clock.h" 8 #include "base/test/simple_test_tick_clock.h"
9 #include "cc/output/begin_frame_args.h" 9 #include "cc/output/begin_frame_args.h"
10 #include "cc/test/ordered_simple_task_runner.h" 10 #include "cc/test/ordered_simple_task_runner.h"
(...skipping 718 matching lines...) Expand 10 before | Expand all | Expand 10 after
729 scheduler_->DidAnimateForInputOnCompositorThread(); 729 scheduler_->DidAnimateForInputOnCompositorThread();
730 EnableIdleTasks(); 730 EnableIdleTasks();
731 RunUntilIdle(); 731 RunUntilIdle();
732 EXPECT_THAT(run_order, 732 EXPECT_THAT(run_order,
733 testing::ElementsAre(std::string("D1"), std::string("C1"), 733 testing::ElementsAre(std::string("D1"), std::string("C1"),
734 std::string("D2"), std::string("C2"), 734 std::string("D2"), std::string("C2"),
735 std::string("I1"))); 735 std::string("I1")));
736 EXPECT_EQ(RendererScheduler::UseCase::COMPOSITOR_GESTURE, CurrentUseCase()); 736 EXPECT_EQ(RendererScheduler::UseCase::COMPOSITOR_GESTURE, CurrentUseCase());
737 } 737 }
738 738
739 // TODO(skyostil): Re-enable once timer blocking is re-enabled.
740 TEST_F( 739 TEST_F(
741 RendererSchedulerImplTest, 740 RendererSchedulerImplTest,
742 DISABLED_TestCompositorPolicy_ExpensiveTimersDontRunWhenMainThreadOnCritical Path) { 741 TestCompositorPolicy_ExpensiveTimersDontRunWhenMainThreadOnCriticalPath) {
743 std::vector<std::string> run_order; 742 std::vector<std::string> run_order;
744 743
745 SimulateExpensiveTasks(timer_task_runner_); 744 SimulateExpensiveTasks(timer_task_runner_);
746 745
747 // Timers should now be disabled during main thread user user interactions. 746 // Timers should now be disabled during main thread user user interactions.
748 PostTestTasks(&run_order, "C1 T1"); 747 PostTestTasks(&run_order, "C1 T1");
749 748
750 // Trigger main_thread_gesture UseCase 749 // Trigger main_thread_gesture UseCase
751 scheduler_->DidAnimateForInputOnCompositorThread(); 750 scheduler_->DidAnimateForInputOnCompositorThread();
752 cc::BeginFrameArgs begin_frame_args1 = cc::BeginFrameArgs::Create( 751 cc::BeginFrameArgs begin_frame_args1 = cc::BeginFrameArgs::Create(
(...skipping 1343 matching lines...) Expand 10 before | Expand all | Expand 10 after
2096 EXPECT_EQ(RendererScheduler::UseCase::NONE, CurrentUseCase()); 2095 EXPECT_EQ(RendererScheduler::UseCase::NONE, CurrentUseCase());
2097 EXPECT_TRUE(HaveSeenABeginMainframe()); 2096 EXPECT_TRUE(HaveSeenABeginMainframe());
2098 EXPECT_TRUE(LoadingTasksSeemExpensive()); 2097 EXPECT_TRUE(LoadingTasksSeemExpensive());
2099 EXPECT_FALSE(TimerTasksSeemExpensive()); 2098 EXPECT_FALSE(TimerTasksSeemExpensive());
2100 EXPECT_TRUE(TouchStartExpectedSoon()); 2099 EXPECT_TRUE(TouchStartExpectedSoon());
2101 EXPECT_THAT(run_order, testing::ElementsAre(std::string("D1"))); 2100 EXPECT_THAT(run_order, testing::ElementsAre(std::string("D1")));
2102 } 2101 }
2103 2102
2104 2103
2105 } // namespace scheduler 2104 } // namespace scheduler
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698