Issue 138123002: Experimental lexer: reset literals if the source was moved by GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138123002: Experimental lexer: reset literals if the source was moved by GC. (Closed)

Created:
6 years, 11 months ago by ulan

Modified:
6 years, 11 months ago

Reviewers:
marja

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/parser

Visibility:
Public.

Experimental lexer: reset literals if the source was moved by GC. R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18585

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	src/lexer/experimental-scanner.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

ulan

PTAL There is another issue with literals and GC that is not fixed by this ...

6 years, 11 months ago (2014-01-14 12:07:16 UTC) #1

marja

lgtm, and ouch for the parser literal becoming invalid :( Maybe we should just keep ...

6 years, 11 months ago (2014-01-14 12:37:54 UTC) #2

ulan

6 years, 11 months ago (2014-01-14 13:13:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18585 (presubmit successful).