Issue 13812019: Fix arguments to dart2js in windows bat file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13812019: Fix arguments to dart2js in windows bat file (Closed)

Created:
7 years, 8 months ago by ricow1

Modified:
7 years, 8 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix arguments to dart2js in windows bat file Wrongly assigned the library path to vm options Committed: https://code.google.com/p/dart/source/detail?r=21248

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	sdk/bin/dart2js.bat	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #1 manually as r21248 (presubmit successful).

7 years, 8 months ago (2013-04-11 06:16:51 UTC) #3

ahe

7 years, 8 months ago (2013-04-11 07:07:01 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/13812019/diff/1/sdk/bin/dart2js.bat
File sdk/bin/dart2js.bat (right):

https://codereview.chromium.org/13812019/diff/1/sdk/bin/dart2js.bat#newcode30
sdk/bin/dart2js.bat:30: set EXTRA_OPTIONS=%EXTRA_OPTIONS%
--library-root=%SDK_DIR%
Quotes around %SDK_DIR%?

Expand Messages | Collapse Messages