Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 1381163002: Add a flag to disable partial raster in renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove "--enable-persistent-gpu-memory-buffer" Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 2716aa07f0941cea3221c97f718b379a04f6f977..352067b88a326b4cb41b94a27796a3299fa88abc 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -1138,13 +1138,16 @@ static void AppendCompositorCommandLineFlags(base::CommandLine* command_line) {
if (IsZeroCopyUploadEnabled())
command_line->AppendSwitch(switches::kEnableZeroCopy);
- if (IsPersistentGpuMemoryBufferEnabled())
- command_line->AppendSwitch(switches::kEnablePersistentGpuMemoryBuffer);
+ if (IsPartialRasterEnabled())
+ command_line->AppendSwitch(switches::kEnablePartialRaster);
if (IsForceGpuRasterizationEnabled())
command_line->AppendSwitch(switches::kForceGpuRasterization);
- gfx::BufferUsage buffer_usage = IsPersistentGpuMemoryBufferEnabled()
+ // Persistent buffers may come at a performance hit (not all platform specific
+ // buffers support it), so only enable them if partial raster is enabled and
+ // we are actually going to use them.
+ gfx::BufferUsage buffer_usage = IsPartialRasterEnabled()
? gfx::BufferUsage::PERSISTENT_MAP
: gfx::BufferUsage::MAP;
std::vector<unsigned> image_targets(

Powered by Google App Engine
This is Rietveld 408576698