Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job.cc

Issue 1381153004: Service Worker: Change the criteria for bumping the last update check time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Avoid reading disk for first time registrations. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_write_to_cache_job.cc
diff --git a/content/browser/service_worker/service_worker_write_to_cache_job.cc b/content/browser/service_worker/service_worker_write_to_cache_job.cc
index fc3074d9a934ad4d239533bf083cbf41592bfaaf..2c3e9791763746bea94fd91efe9be9070de61278 100644
--- a/content/browser/service_worker/service_worker_write_to_cache_job.cc
+++ b/content/browser/service_worker/service_worker_write_to_cache_job.cc
@@ -340,7 +340,8 @@ void ServiceWorkerWriteToCacheJob::OnResponseStarted(
version_->SetMainScriptHttpResponseInfo(net_request_->response_info());
}
- if (net_request_->response_info().network_accessed)
+ if (net_request_->response_info().network_accessed &&
+ !(net_request_->response_info().was_cached))
falken 2015/12/07 07:40:33 nit: I prefer to add braces to this if now that it
jungkees 2015/12/15 13:07:46 Done.
version_->embedded_worker()->OnNetworkAccessedForScriptLoad();
http_info_.reset(new net::HttpResponseInfo(net_request_->response_info()));

Powered by Google App Engine
This is Rietveld 408576698