chrome/browser/thumbnails/content_analysis_unittest.cc - Issue 13811056: Added variable initialization (valgrind complains).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/thumbnails/content_analysis_unittest.cc

Issue 13811056: Added variable initialization (valgrind complains). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/thumbnails/content_analysis_unittest.cc

diff --git a/chrome/browser/thumbnails/content_analysis_unittest.cc b/chrome/browser/thumbnails/content_analysis_unittest.cc

index f85d205978bc727e208a613e3656c0a688394399..ae395acb6c90a8a9aff11e63a9f660ce43ca1d33 100644

--- a/chrome/browser/thumbnails/content_analysis_unittest.cc

+++ b/chrome/browser/thumbnails/content_analysis_unittest.cc

@@ -470,7 +470,7 @@ TEST_F(ThumbnailContentAnalysisTest, CreateRetargettedThumbnailImage) {

EXPECT_LT(result.height(), image_size.height());

// TODO(motek): this test is problematic/flaky on Win7. Investigate.

#if !defined(OS_WIN)

- int histogram[256];

+ int histogram[256] = { 0 };

grt (UTC plus 2) 2013/04/18 13:38:47 nit: remove the zero. " = {};" will do the right t

motek. 2013/04/18 14:03:44 Done.

color_utils::BuildLumaHistogram(result, histogram);

int non_zero_color_count = std::count_if(

histogram, histogram + 256, std::bind2nd(std::greater<int>(), 0));

« no previous file with comments | « no previous file | no next file » | no next file with comments »