Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 13811054: Update code generator for dartium dart:html with typeddata. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/scripts/htmldartgenerator.py
diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py
index 393d7b4164f991354dbae39ad204b2860636e728..c078b7ceb4289104532f5d1c056ed5a2ea926915 100644
--- a/tools/dom/scripts/htmldartgenerator.py
+++ b/tools/dom/scripts/htmldartgenerator.py
@@ -234,25 +234,6 @@ class HtmlDartGenerator(object):
argument = signatures[signature_index][i]
parameter_name = parameter_names[i]
test_type = self._DartType(argument.type.id)
- # TODO(antonm): temporary ugly hack to be able to work with existing
- # typed array types as well as dart:typeddata types until
- # the transition to dart:typeddata is complete for both dart2js
- # and dartium.
- from systemnative import DartiumBackend
- if isinstance(self, DartiumBackend):
- if argument.type.id == 'ArrayBufferView':
- checks.append(
- '(%(name)s is ArrayBufferView '
- '|| %(name)s is _typeddata.TypedData '
- '|| %(name)s == null)' % {'name': parameter_name})
- continue
- if argument.type.id == 'ArrayBuffer':
- checks.append(
- '(%(name)s is ArrayBuffer '
- '|| %(name)s is _typeddata.ByteBuffer '
- '|| %(name)s == null)' % {'name': parameter_name})
- continue
- # end of ugly hack.
if test_type in ['dynamic', 'Object']:
checks.append('?%s' % parameter_name)
elif not can_omit_type_check(test_type, i):

Powered by Google App Engine
This is Rietveld 408576698