Autofill:Autocheckout: Enable Autocheckout for finch experimenting

components/autofill/renderer/form_autofill_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/renderer/form_autofill_util.h"
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/scoped_vector.h"
+#include "base/metrics/field_trial.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "components/autofill/common/autofill_switches.h"
 #include "components/autofill/common/form_data.h"
 #include "components/autofill/common/form_field_data.h"
 #include "components/autofill/common/web_element_descriptor.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebString.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebVector.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebElement.h"
@@ skipping 51 matching lines @@
 
 bool HasTagName(const WebNode& node, const WebKit::WebString& tag) {
   return node.isElementNode() && node.toConst<WebElement>().hasTagName(tag);
 }
 
 bool IsAutofillableElement(const WebFormControlElement& element) {
   const WebInputElement* input_element = toWebInputElement(&element);
   return IsAutofillableInputElement(input_element) || IsSelectElement(element);
 }
 
+bool IsAutocheckoutEnabled() {
+   return base::FieldTrialList::FindFullName("Autocheckout") == "Yes" ||

[Ilya Sherman, 2013/04/13 01:12:09]

I'm not sure that all field trials are automatically sent to the renderer
process.  You might want to double-check that this works correctly.

[Alexei Svitkine (slow), 2013/04/15 15:24:13]

I believe we only tell the renderer of studies that have had their group value
queried by the browser process. So to make sure its visible in the renderer,
ensure that you do a base::FieldTrialList::FindFullName("Autocheckout") in the
browser prior to that.

[Raman Kakilate, 2013/04/15 15:49:52]

Done. Verified that Autocheckout field trial is in "Yes" state in renderer
process.

+       CommandLine::ForCurrentProcess()->HasSwitch(
+           switches::kEnableExperimentalFormFilling);
+}
+
 // Check whether the given field satisfies the REQUIRE_AUTOCOMPLETE requirement.
 // When Autocheckout is enabled, this requirement is enforced in the browser
 // process rather than in the renderer process, and hence all fields are
 // considered to satisfy this requirement.
 bool SatisfiesRequireAutocomplete(const WebInputElement& input_element) {
-  return input_element.autoComplete() ||
-      CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kEnableExperimentalFormFilling);
+  return input_element.autoComplete() || IsAutocheckoutEnabled();
 }
 
 // Appends |suffix| to |prefix| so that any intermediary whitespace is collapsed
 // to a single space.  If |force_whitespace| is true, then the resulting string
 // is guaranteed to have a space between |prefix| and |suffix|.  Otherwise, the
 // result includes a space only if |prefix| has trailing whitespace or |suffix|
 // has leading whitespace.
 // A few examples:
 //  * CombineAndCollapseWhitespace("foo", "bar", false)       -> "foobar"
 //  * CombineAndCollapseWhitespace("foo", "bar", true)        -> "foo bar"
@@ skipping 921 matching lines @@
       continue;
 
     if (input_element->isAutofilled())
       return true;
   }
 
   return false;
 }
 
 }  // namespace autofill