expose spatial navigation to chromium

expose spatial navigation to chromium

This is a prereq for testing spatial navigation in content_shell/chromium.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148490

[Mostyn Bramley-Moore, 2013-04-12 12:08:59]

This patch makes it possible for chromium code to enable spatial navigation in
blink.  I have a chromium patch which adds a new "--enable-spatial-navigation"
command line flag to be able to test this in content_shell/chromium (I will
upload the second patch once this one is accepted).

[esprehn, 2013-04-15 17:27:27]

On 2013/04/12 12:08:59, Mostyn Bramley-Moore wrote:
> This patch makes it possible for chromium code to enable spatial navigation in
> blink.  I have a chromium patch which adds a new "--enable-spatial-navigation"
> command line flag to be able to test this in content_shell/chromium (I will
> upload the second patch once this one is accepted).

The Settings object doesn't seem to have a setSpatialNavigationEnabled method
yet so this can't compile. Is there another patch that adds that?

[Mostyn Bramley-Moore, 2013-04-15 17:44:51]

On 2013/04/15 17:27:27, esprehn wrote:
> The Settings object doesn't seem to have a setSpatialNavigationEnabled method
> yet so this can't compile. Is there another patch that adds that?

It's in Source/WebKit/chromium/src/WebSettingsImpl.cpp, unless I misunderstand
the question.  

Note that you also need this patch in the chromium repo:
https://codereview.chromium.org/14110006/

[esprehn, 2013-04-15 20:02:54]

I see, the setting was already added to Settings.in so those setters exist in
WebCore::Settings.

lgtm

[jamesr, 2013-04-15 20:06:13]

public API lgtm

[darin (slow to review), 2013-04-16 19:59:41]

Committed patchset #2 manually as r148490 (presubmit successful).