gm: hide list of tests with ignored errors, by default

gm: hide list of tests with ignored errors, by default
Committed: https://code.google.com/p/skia/source/detail?r=8591

[epoger, 2013-04-09 20:08:26]

https://codereview.chromium.org/13811031/diff/1/gm/gmmain.cpp
File gm/gmmain.cpp (right):

https://codereview.chromium.org/13811031/diff/1/gm/gmmain.cpp#newcode336
gm/gmmain.cpp:336:
this->DisplayResultTypeSummary(static_cast<ErrorType>(typeInt));
patchset 1 extracts some logic into its own method... no behavioral change yet.

[epoger, 2013-04-09 20:19:50]

https://codereview.chromium.org/13811031/diff/2001/gm/gmmain.cpp
File gm/gmmain.cpp (right):

https://codereview.chromium.org/13811031/diff/2001/gm/gmmain.cpp#newcode319
gm/gmmain.cpp:319: if (!isIgnorableType || verbose) {
Patchset 2 changes gm's behavior: only write out the list of tests for a given
ErrorType if:
1. it's an ErrorType that would cause nonzero return value, OR
2. we are running in verbose mode

https://codereview.chromium.org/13811031/diff/2001/gm/tests/run.sh
File gm/tests/run.sh (right):

https://codereview.chromium.org/13811031/diff/2001/gm/tests/run.sh#newcode140
gm/tests/run.sh:140: gm_test "--verbose --hierarchy --match selftest1 $CONFIGS
-r $GM_INPUTS/images/identical-bytes"
"$GM_OUTPUTS/compared-against-identical-bytes-images"
all the self-tests run in verbose mode now, so we can make sure they're behaving
as expected

[epoger, 2013-04-09 20:37:07]

Ready for review at patchset 3...

Mike- please let me know if the behavior is to your liking
Eric- please let me know if the implementation is to your liking :-)

https://codereview.chromium.org/13811031/diff/9001/gm/tests/outputs/nonverbos...
File gm/tests/outputs/nonverbose/output-expected/command_line (right):

https://codereview.chromium.org/13811031/diff/9001/gm/tests/outputs/nonverbos...
gm/tests/outputs/nonverbose/output-expected/command_line:1: out/Debug/gm
--hierarchy --match selftest1 --config 8888 565 -r
gm/tests/inputs/images/empty-dir --writeJsonSummaryPath
gm/tests/outputs/nonverbose/output-actual/json-summary.txt
patchset 3 adds a test run WITHOUT --verbose

https://codereview.chromium.org/13811031/diff/9001/gm/tests/outputs/nonverbos...
File gm/tests/outputs/nonverbose/output-expected/stdout (right):

https://codereview.chromium.org/13811031/diff/9001/gm/tests/outputs/nonverbos...
gm/tests/outputs/nonverbose/output-expected/stdout:7: GM: [ ] 2
MissingExpectations
in non-verbose mode, the MissingExpectations are not listed (because they don't
cause an error anyway)

[reed1, 2013-04-09 21:54:10]

lgtm

[borenet, 2013-04-09 22:09:37]

LGTM as well

[epoger, 2013-04-10 15:25:03]

Committed patchset #7 manually as r8591 (presubmit successful).