History: Fix alignment issues in search.

History: Fix alignment issues in search.

https://codereview.chromium.org/13534002/ caused the search result snippet to
be misaligned in the history page.

R=dubroy@chromium.org
BUG=228818
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193403

[Sergiu, 2013-04-09 11:43:02]

Please take a look, ideally on Android as well.
Thanks!

[Patrick Dubroy, 2013-04-10 12:52:11]

https://codereview.chromium.org/13811015/diff/1/chrome/browser/resources/hist...
File chrome/browser/resources/history/history.css (right):

https://codereview.chromium.org/13811015/diff/1/chrome/browser/resources/hist...
chrome/browser/resources/history/history.css:145: display: -webkit-flex;
I'm pretty sure you can get rid of all 3 declarations inside this rule.

https://codereview.chromium.org/13811015/diff/1/chrome/browser/resources/hist...
chrome/browser/resources/history/history.css:349: -webkit-flex-direction: row;
You can omit this, it's the default.

https://codereview.chromium.org/13811015/diff/1/chrome/browser/resources/hist...
chrome/browser/resources/history/history.css:350: display: -webkit-flex;
You'll need to add

  .entry-box-container {
    display: block;
  }

To history_mobile.css to get it work on Android, and remove the change that was
added in
https://codereview.chromium.org/13724008/diff/1/chrome/browser/resources/hist....

[Sergiu, 2013-04-10 13:46:46]

https://codereview.chromium.org/13811015/diff/1/chrome/browser/resources/hist...
File chrome/browser/resources/history/history.css (right):

https://codereview.chromium.org/13811015/diff/1/chrome/browser/resources/hist...
chrome/browser/resources/history/history.css:145: display: -webkit-flex;
On 2013/04/10 12:52:11, dubroy wrote:
> I'm pretty sure you can get rid of all 3 declarations inside this rule.

Yeah, seems to work fine.

https://codereview.chromium.org/13811015/diff/1/chrome/browser/resources/hist...
chrome/browser/resources/history/history.css:349: -webkit-flex-direction: row;
On 2013/04/10 12:52:11, dubroy wrote:
> You can omit this, it's the default.

Done.

https://codereview.chromium.org/13811015/diff/1/chrome/browser/resources/hist...
chrome/browser/resources/history/history.css:350: display: -webkit-flex;
On 2013/04/10 12:52:11, dubroy wrote:
> You'll need to add
> 
>   .entry-box-container {
>     display: block;
>   }
> 
> To history_mobile.css to get it work on Android, and remove the change that
was
> added in
>
https://codereview.chromium.org/13724008/diff/1/chrome/browser/resources/hist....

Done.

[Patrick Dubroy, 2013-04-10 14:03:16]

lgtm, and verified that it works on Android.

[commit-bot: I haz the power, 2013-04-10 15:17:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergiu@chromium.org/13811015/11001

[commit-bot: I haz the power, 2013-04-10 17:13:51]

Change committed as 193403