Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: build/common.gypi

Issue 13811009: Fix build warnings with gcc4.8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use conditions to set flag only for gcc>=4.8 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 0fe8b73a27892551156cd5ee253a5398b17a5165..de0c1a3387a135a831af56ed658607dbdcfab296 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2558,6 +2558,16 @@
'-fvisibility=hidden',
'-pipe',
],
+ 'conditions': [
qiankun 2013/04/13 01:21:30 Add a conditions section to check if gcc_version>=
Raphael Kubo da Costa (rakuco) 2013/04/15 10:57:07 Have you tried running `gyp_chromium' with the CHR
+ # Don't warn about the "typedef 'foo' locally defined but not used"
+ # for gcc 4.8.
+ # TODO: remove this flag once all builds work. See crbug.com/227506
+ [ 'gcc_version>=48', {
+ 'cflags': [
+ '-Wno-unused-local-typedefs',
+ ],
+ }],
+ ],
'cflags_cc': [
'-fno-rtti',
'-fno-threadsafe-statics',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698