Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1381083004: Improving error messages when adding properties to non JSObject receiver in (Closed)

Created:
5 years, 2 months ago by Camillo Bruni
Modified:
5 years, 2 months ago
Reviewers:
rossberg, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Improving error messages when adding properties to non JSObject receiver in strict mode. LOG=N BUG=chromium:423739 Committed: https://crrev.com/3ac2973b292192a73b2a0028ecad8a962f94d952 Cr-Commit-Position: refs/heads/master@{#31192}

Patch Set 1 #

Patch Set 2 : fixing read only length error messag on JSArray #

Patch Set 3 : fixing more test expectations #

Total comments: 2

Patch Set 4 : removing unused branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -27 lines) Patch
M src/messages.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 6 chunks +35 lines, -12 lines 0 comments Download
M test/mjsunit/harmony/super.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/Object-defineProperty-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M test/webkit/fast/js/basic-strict-mode-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/primitive-property-access-edge-cases-expected.txt View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M test/webkit/fast/js/read-modify-eval-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381083004/1
5 years, 2 months ago (2015-10-05 13:57:44 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 2 months ago (2015-10-05 13:57:45 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381083004/1
5 years, 2 months ago (2015-10-05 13:58:33 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/10239)
5 years, 2 months ago (2015-10-05 14:10:47 UTC) #8
Camillo Bruni
PTAL see changes in messages.h for the new error messages.
5 years, 2 months ago (2015-10-07 14:07:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381083004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381083004/40001
5 years, 2 months ago (2015-10-07 14:07:55 UTC) #12
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-07 14:07:57 UTC) #14
Toon Verwaest
https://codereview.chromium.org/1381083004/diff/40001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1381083004/diff/40001/src/objects.cc#newcode3943 src/objects.cc:3943: return WriteToReadOnlyProperty(it, value, language_mode); This case shouldn't happen I ...
5 years, 2 months ago (2015-10-07 14:21:37 UTC) #15
Camillo Bruni
https://codereview.chromium.org/1381083004/diff/40001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1381083004/diff/40001/src/objects.cc#newcode3943 src/objects.cc:3943: return WriteToReadOnlyProperty(it, value, language_mode); On 2015/10/07 at 14:21:37, Toon ...
5 years, 2 months ago (2015-10-07 14:30:42 UTC) #16
Toon Verwaest
lgtm
5 years, 2 months ago (2015-10-07 15:38:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381083004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381083004/60001
5 years, 2 months ago (2015-10-09 08:49:36 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-09 09:12:35 UTC) #20
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 09:12:56 UTC) #21
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/3ac2973b292192a73b2a0028ecad8a962f94d952
Cr-Commit-Position: refs/heads/master@{#31192}

Powered by Google App Engine
This is Rietveld 408576698